Medium

NLTK: Uncontrolled recursion in Toolbox settings helpers causes denial of service via deeply nested input

  • Disclosed: 19.11.2026
  • Updated: 20.11.2026 01:17

Root Cause

The Toolbox settings-tree helpers recurse over the parsed element tree without any depth bound. _to_settings_string (nltk/toolbox.py:418), remove_blanks (nltk/toolbox.py:432), add_default_fields (nltk/toolbox.py:451), _sort_fields (nltk/toolbox.py:484), and add_blank_lines (nltk/toolbox.py:502,516) each recurse once per element level with no depth counter or explicit stack. The producer ToolboxSettings.parse builds the element tree iteratively, so nesting depth is driven entirely by attacker-supplied \+marker / \-marker pairs.

Impact

An application that parses an untrusted Toolbox settings file and then serialises or transforms it through any of the public helper functions aborts with an unhandled RecursionError, terminating the affected operation or request worker (denial of service, CWE-674). The recursion is pure Python, yielding a catchable RecursionError rather than memory corruption or code execution. Confidentiality and integrity are unaffected.

Attack Chain

  1. The application parses an untrusted settings file via ToolboxSettings.open_string / open plus parse, producing an N-deep element tree; parsing is iterative and completes without error.
  2. The application passes the tree to a public helper — to_settings_string, remove_blanks, add_default_fields, sort_fields, or add_blank_lines — as in the module's own parse-then-serialise round trip.
  3. The helper recurses once per element level with no depth guard, consuming call-stack frames. This holds even when the helper's configuration dictionaries are empty.
  4. Once the nesting depth exceeds the interpreter recursion limit, an unhandled RecursionError propagates out of the public API.

Bypass Evidence

Against the shipped source at the default recursion limit, a settings input nested 5 levels deep traverses cleanly through every helper, while a well-formed input nested 5000 levels deep drives each of the five helpers to an unhandled RecursionError; the iterative parse builds the 4999-deep tree without error, isolating the fault to the recursive helpers. The config-taking helpers (add_default_fields, sort_fields, add_blank_lines) recurse to failure even with empty configuration dictionaries. A repository-wide search confirms no depth guard exists anywhere in this module.

Suggested Fix

Cap nesting depth at the shared producer ToolboxSettings.parse (the choke point that builds the tree), or convert the five helpers to iterative traversals / add a shared recursion-depth bound, so all consumers are protected by one fix.

Reported by pi (GitHub: @manus-pi).

Fix status (2026-09-28)

Status: MERGED on develop (unreleased; v3.10.3 of 2026-08-12 predates the fix).

PR: #3885 "Bound recursion depth in parsers and traversal helpers" (ekaf), merged 2026-09-11, merge commit e521ecafc on develop.

Fix commit: 0b6975377 (nltk/toolbox.py: the settings helpers stop at MAX_TOOLBOX_DEPTH=500 with ValueError).

Probe: nltk/test/unit/security_probes/ghsa_f2h2_f4fc_p978.py (added in 2a6704952 on that PR); verdict on develop 2fa3f48fe: FIXED (bounded during parse (ValueError)).

Release: none yet; no release tag contains e521ecafc.

Affected software

Click a technology to see all vulnerabilities affecting it.

PlatformPackageVulnerable versionsFixed in
Python (PyPI) nltk < 3.10.4 3.10.4

References

CVSS score 5.3/10
CVSS vector
CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:L
Weakness (CWE)
CWE-674
Platform
Python (PyPI)
Package
nltk
Disclosed
19.11.2026
Updated
20.11.2026 01:17

Sources and licenses

OSV / GitHub Advisory Database - GHSA-f2h2-f4fc-p978 - CC BY 4.0

Vulnerability history: nltk

All published vulnerabilities of this package (Python (PyPI)), newest first. Shows whether this is a one-off slip or a package that needs watching.

All (79) in the archive
Total entries
79
First → latest
08.2019 11.2026
Without a fix
5
Exploited in attacks
0

Severity breakdown

  • Critical 5
  • High 41
  • Medium 31
  • Low 2

Disclosures per year

  1. 2019: 1
  2. 2020: 0
  3. 2021: 2
  4. 2022: 1
  5. 2023: 0
  6. 2024: 1
  7. 2025: 0
  8. 2026: 74
Severity:
  1. NLTK: Uncontrolled recursion in Toolbox settings helpers causes denial of service via deeply nested input this entry
    Medium · 5.3 CVE-2026-129228 < 3.10.4 3.10.4
  2. High CVE-2026-79674 < 3.10.3 3.10.3
Show more (20) Showing 20 of 47

Know which vulnerabilities affect your application

With the DockRay integration and software inventory enabled, DockRay checks reported component versions against known vulnerabilities and notifies you about confirmed matches. Coverage depends on the supported technology and available advisory data.

Connect your application
DockRay newsletter

Application security in your inbox

Important vulnerabilities, actionable guidance and practical advice for your applications. Choose your technologies and follow what matters to your project.

  • A daily digest of new vulnerabilities, critical ones included.
  • Notifications about important updates.
  • Practical advice on application security and monitoring.

Leave empty to receive updates for every technology.

Free to subscribe. Unsubscribe with one click in any email.